Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lib-js-util-base instead of lodash #255

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Use lib-js-util-base instead of lodash #255

merged 3 commits into from
Sep 26, 2023

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Sep 26, 2023

This PR adds ability to use lib-js-util-base lib instead of the lodash

Base changes:

  • uses lib-js-util-base lib instead of lodash
  • removes lodash.isObject usage as redundant and not used anywhere

ezewer
ezewer approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ezewer ezewer merged commit 5577d43 into bitfinexcom:staging Sep 26, 2023
This was referenced Oct 4, 2023
Merged
Merged
@ZIMkaRU ZIMkaRU deleted the refactoring/use-lib-js-util-base-instead-of-lodash branch March 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZIMkaRU @ezewer