Prevent showing error modal dialog due to inet issue #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
Merged
ZIMkaRU
deleted the
bugfix/prevent-showing-error-modal-dialog-due-to-inet-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents showing error modal dialog due to inet issue
When the sync starts we send a ping request to bfx api to check that api is available
https://github.com/bitfinexcom/bfx-reports-framework/blob/master/workers/loc.api/sync/index.js#L127
https://github.com/bitfinexcom/bfx-reports-framework/blob/master/workers/loc.api/service.report.framework.js#L258
The idea is to not show error modal dialog for issues, just show error toast via UI when fetching the corresponding error with progress event via WS
Depends on this PR: