Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max listeners exceeded warning #229

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Jul 24, 2023

This PR fixes the #215 related to MaxListenersExceededWarning warning for the electron windows


Basic changes:

  • Adds manager for closed window event being once bubbled, for better handling
  • Fixes download progress showing for the auto-update in cases when the event happens faster than the alert fires

Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prdn prdn merged commit 39da38d into bitfinexcom:beta Jul 25, 2023
This was referenced Aug 2, 2023
@ZIMkaRU ZIMkaRU deleted the bugfix/fix-max-listeners-exceeded-warning branch March 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants