Merge pull request #263 from ZIMkaRU/feature/bump-electron-version-up…

…-to-27 Bump electron version up to 27
bitfinexcom · Oct 31, 2023 · 8b5ab51 · 8b5ab51
2 parents 58d0abd + 53fa2b5
commit 8b5ab51
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/build-electron-app.yml b/.github/workflows/build-electron-app.yml
@@ -110,7 +110,7 @@ jobs:
         echo "IS_BFX_API_STAGING=1" >> $GITHUB_ENV
     - uses: actions/setup-node@v3
       with:
-        node-version: 18.15.0
+        node-version: 18.17.1
     - name: Cache Electron binaries
       id: electron-cache
       uses: actions/cache@v3

diff --git a/Dockerfile.linux-builder b/Dockerfile.linux-builder
@@ -1,6 +1,6 @@
 FROM electronuserland/builder:18
 
-ARG NODE_VERSION="18.15.0"
+ARG NODE_VERSION="18.17.1"
 
 ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
 ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

diff --git a/Dockerfile.mac-builder b/Dockerfile.mac-builder
@@ -1,6 +1,6 @@
 FROM electronuserland/builder:18
 
-ARG NODE_VERSION="18.15.0"
+ARG NODE_VERSION="18.17.1"
 
 ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
 ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

diff --git a/Dockerfile.win-builder b/Dockerfile.win-builder
@@ -1,6 +1,6 @@
 FROM electronuserland/builder:18-wine
 
-ARG NODE_VERSION="18.15.0"
+ARG NODE_VERSION="18.17.1"
 
 ENV IS_BFX_API_STAGING=${IS_BFX_API_STAGING:-0}
 ENV IS_DEV_ENV=${IS_DEV_ENV:-0}

diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
   "author": "bitfinex.com",
   "main": "index.js",
   "engine": {
-    "node": ">=18.15.0"
+    "node": ">=18.17.1"
   },
   "license": "Apache-2.0",
   "dependencies": {
@@ -36,7 +36,7 @@
   "devDependencies": {
     "@mapbox/node-pre-gyp": "1.0.6",
     "app-builder-bin": "4.1.0",
-    "electron": "25.8.1",
+    "electron": "27.0.2",
     "electron-builder": "23.6.0",
     "mocha": "10.2.0",
     "standard": "16.0.4"

diff --git a/scripts/helpers/install-nodejs.sh b/scripts/helpers/install-nodejs.sh
@@ -13,7 +13,7 @@ script as required NodeJS version!${COLOR_NORMAL}" >&2
   exit 1
 fi
 
-version="${1:-"18.15.0"}"
+version="${1:-"18.17.1"}"
 
 echo -e "\n${COLOR_BLUE}Installing the NodeJS v$version...${COLOR_NORMAL}"
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,7 @@ script as required NodeJS version!${COLOR_NORMAL}" >&2 @@
       exit 1
     fi
-    version="${1:-"18.15.0"}"
+    version="${1:-"18.17.1"}"
     echo -e "\n${COLOR_BLUE}Installing the NodeJS v$version...${COLOR_NORMAL}"
@@ Expand Down @@