Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor PnL #29

Merged
merged 7 commits into from
Aug 2, 2022
Merged

refactor PnL #29

merged 7 commits into from
Aug 2, 2022

Conversation

tarcisiozf
Copy link
Contributor

@tarcisiozf tarcisiozf commented Jul 31, 2022

  • use new pnl fields

@tarcisiozf tarcisiozf changed the title use fork refactor PnL Jul 31, 2022
package.json Outdated
@@ -37,7 +37,7 @@
"dependencies": {
"bfx-api-node-core": "^1.5.8",
"bfx-api-node-util": "^1.0.2",
"bfx-hf-strategy": "git+https://github.com/bitfinexcom/bfx-hf-strategy.git#v1.5.5",
"bfx-hf-strategy": "git+https://github.com/tarcisiozf/bfx-hf-strategy.git#refactor-pnl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for merge

@tarcisiozf tarcisiozf marked this pull request as ready for review July 31, 2022 22:03
Copy link
Contributor

@avsek477 avsek477 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarcisiozf tarcisiozf merged commit 620cad2 into bitfinexcom:master Aug 2, 2022
@tarcisiozf tarcisiozf deleted the refactor-pnl branch August 2, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants