use trade data for price feed (#30)

* wip * update with mts * update version Co-authored-by: Tarcisio Ferraz <[email protected]>
bitfinexcom · Aug 16, 2022 · ce1a4fb · ce1a4fb
1 parent f382324
commit ce1a4fb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 27 deletions.
diff --git a/index.js b/index.js
@@ -40,16 +40,16 @@ class LiveStrategyExecution extends EventEmitter {
   constructor (args) {
     super()
 
-    const { strategy = {}, ws2Manager, rest, strategyOptions, priceFeed, perfManager } = args
+    const { strategy, ws2Manager, rest, strategyOptions, priceFeed, perfManager } = args
 
     this.strategyState = {
       ...strategy,
       emit: this.emit.bind(this)
     }
 
-    this.ws2Manager = ws2Manager || {}
-    this.rest = rest || {}
-    this.strategyOptions = strategyOptions || {}
+    this.ws2Manager = ws2Manager
+    this.rest = rest
+    this.strategyOptions = strategyOptions
     this.priceFeed = priceFeed
     this.perfManager = perfManager
 
@@ -108,18 +108,23 @@ class LiveStrategyExecution extends EventEmitter {
       throw new Error('WS2 manager not available')
     }
 
-    const { trades, symbol, timeframe } = this.strategyOptions
+    const { trades: includeTrades, symbol, timeframe } = this.strategyOptions
     const candleKey = `trade:${timeframe}:${symbol}`
 
-    if (trades) {
-      this.ws2Manager.onWS('trades', { symbol }, async (trades) => {
-        if (trades.length > 1) { // we don't pass snapshots through
-          return
-        }
+    this.ws2Manager.onWS('trades', { symbol }, async (trades) => {
+      if (trades.length > 1) { // we don't pass snapshots through
+        return
+      }
 
+      if (includeTrades) {
         this._enqueueMessage('trade', trades)
-      })
-    }
+      }
+
+      if (trades.mts > this.lastPriceFeedUpdate) {
+        this.priceFeed.update(trades.price, trades.mts)
+        this.lastPriceFeedUpdate = trades.mts
+      }
+    })
 
     this.ws2Manager.onWS('candles', { key: candleKey }, async (candles) => {
       if (candles.length > 1) { // seeding happens at start via RESTv2
@@ -322,11 +327,6 @@ class LiveStrategyExecution extends EventEmitter {
       return
     }
 
-    if (data.mts > this.lastPriceFeedUpdate) {
-      this.priceFeed.update(data.price)
-      this.lastPriceFeedUpdate = data.mts
-    }
-
     const { symbol } = this.strategyState
     data.symbol = symbol
     debug('recv trade: %j', data)
@@ -341,7 +341,7 @@ class LiveStrategyExecution extends EventEmitter {
    */
   async _processCandleData (data) {
     if (data.mts > this.lastPriceFeedUpdate) {
-      this.priceFeed.update(data[this.candlePrice])
+      this.priceFeed.update(data[this.candlePrice], data.mts)
       this.lastPriceFeedUpdate = data.mts
     }
 
@@ -385,17 +385,12 @@ class LiveStrategyExecution extends EventEmitter {
    * @private
    */
   _subscribeCandleAndTradeEvents () {
-    const { trades, symbol, timeframe } = this.strategyOptions
+    const { symbol, timeframe } = this.strategyOptions
     const candleKey = `trade:${timeframe}:${symbol}`
 
     this.ws2Manager.withSocket((socket) => {
-      let nextSocket = subscribe(socket, 'candles', { key: candleKey })
-
-      if (trades) {
-        nextSocket = subscribe(nextSocket, 'trades', { symbol })
-      }
-
-      return nextSocket
+      const nextSocket = subscribe(socket, 'candles', { key: candleKey })
+      return subscribe(nextSocket, 'trades', { symbol })
     })
   }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bfx-hf-strategy-exec",
-  "version": "2.2.2",
+  "version": "2.3.0",
   "description": "Execution logic for bfx-hf-strategy",
   "main": "./index.js",
   "directories": {