Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump better-sqlite3 up to 8.6.0 #6

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bump better-sqlite3 up to 8.6.0 #6

merged 1 commit into from
Sep 19, 2023

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Sep 15, 2023

This PR bumps better-sqlite3 up to 8.6.0 to have the ability to launch the db driver on Nodejs v18 under electron env at least v25
And also to have this fix random "database is locked" timeouts WiseLibs/better-sqlite3#597

@ZIMkaRU ZIMkaRU marked this pull request as draft September 15, 2023 10:04
@ZIMkaRU ZIMkaRU mentioned this pull request Sep 15, 2023
Merged
ezewer
ezewer approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ZIMkaRU ZIMkaRU marked this pull request as ready for review September 19, 2023 09:49
@prdn prdn merged commit 169c763 into bitfinexcom:main Sep 19, 2023
This was referenced Sep 20, 2023
Merged
Merged
@ZIMkaRU ZIMkaRU mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZIMkaRU @ezewer @prdn