Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve response predicates #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve response predicates #308

wants to merge 2 commits into from

Conversation

supersven
Copy link
Contributor

  • Add test to check response predicates
  • Describe which HTTP status code we're checking against in isVersionConflict.

@supersven
chore: Add test to check response predicates
37fd4ff 
Some cases weren't tested.
@supersven
chore: Improve Haddock of isVersionConflict
d6d914a 
Describe which HTTP status code we're checking against.
blackheaven
blackheaven approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@supersven supersven marked this pull request as ready for review November 6, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackheaven blackheaven blackheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersven @blackheaven