chore: Replace stack by cabal in Makefile #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the stack project configuration has been removed before. GHC 8.x specific targets are removed as this out of any support windows. Targets have been translated. The `ghcid` target is now not executing the tests anymore - but it's now much quicker.
supersven
changed the title
blackheaven
requested changes
Oct 19, 2024
README.md
Outdated
Comment on lines
36
to
39
| The TravisCI tests are run using | ||
| [Stack](http://docs.haskellstack.org/en/stable/README.html) while the Github | ||
| workflows are using Cabal. A convenient development environment is provided by | ||
| Nix and a Makefile, though the project can be built with only Cabal. |
There was a problem hiding this comment.
It's not really true, actually we use GitHub Actions.
There was a problem hiding this comment.
Thanks a lot for the reviews!
I was a bit unsure about this bit. I'm fixing it.
The old stack setup is gone. So, the docs needed some adjustment.
`test-failure-report` is generated by the `test-rerun` Makefile target. No need to commit it (that would even be wrong.)
supersven
force-pushed
the
supersven/no-more-stack
branch
from
adbef70 to
ff6eaf5
Compare
blackheaven
approved these changes
Oct 20, 2024
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the stack project configuration has been removed before. This PR adjusts the
Makefileaccordingly (please see commit messages) and updates the docs.