Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http-types-0.12 #221

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Allow http-types-0.12 #221

merged 2 commits into from
Jan 29, 2018

Conversation

MichaelXavier
Copy link
Collaborator

I tested this locally, but I'm not really sure its the right thing to
put http-types in the default stack.yaml

This is for commercialhaskell/stackage#3232 which blocks
us in katip-elasticsearch downstream

Update: @bitemyapp I noticed you actually put the http-types-0.11 in the stack.yaml in the last commit. Should I instead put 0.12 in the stack.yaml? Wasn't sure about the policy but I may have guessed wrong.

I tested this locally, but I'm not really sure its the right thing to
put http-types in the default stack.yaml

This is for commercialhaskell/stackage#3232 which blocks
us in katip-elasticsearch downstream
@bitemyapp
Copy link
Owner

I noticed you actually put the http-types-0.11 in the stack.yaml in the last commit. Should I instead put 0.12 in the stack.yaml? Wasn't sure about the policy but I may have guessed wrong.

Yeah, to test that we're correctly tracking Stackage and that the build works I put http-types-0.11 in the stack.yaml. Part of the intent is to pin the latest version we're intending to work with in whatever the primary stack.yaml is at the moment. This build permits http-types-0.12 it isn't validating that the build works with that specific version. I'm quite open to alternatives.

@MichaelXavier
Copy link
Collaborator Author

That sounds like a good tradeoff to me. I'll add an explicit http-types version and see what the build says.

@MichaelXavier
Copy link
Collaborator Author

@bitemyapp Tests are green. Mind if I cut, I guess, a D-level release?

@bitemyapp
Copy link
Owner

@MichaelXavier much as I'm loathe to break things up, I think we're eating non-linear Generics pain in the Types modules. Might it be worth to split them into constituent modules to ease compile times? I hate bouncing the CI on this library.

@bitemyapp
Copy link
Owner

Mind if I cut, I guess, a D-level release?

Yeah go ahead, thanks for covering this!

@MichaelXavier
Copy link
Collaborator Author

I've created #222 to discuss the compile time issue.

@MichaelXavier MichaelXavier merged commit bc6cb4c into master Jan 29, 2018
@MichaelXavier MichaelXavier deleted the http-types-0-12 branch January 29, 2018 21:24
@MichaelXavier
Copy link
Collaborator Author

Released at 0.15.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants