Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stats aggregation #177

Merged
merged 2 commits into from
Mar 23, 2017
Merged

add stats aggregation #177

merged 2 commits into from
Mar 23, 2017

Conversation

shmish111
Copy link

No description provided.

@shmish111
Copy link
Author

Looks like Travis timed out one of the builds, all others passed all tests etc so I'm pretty sure it's fine

@MichaelXavier
Copy link
Collaborator

I've restarted that build. Seems like the larger your built matrix the more likely you'll end up getting a rotten Travis run.

@shmish111
Copy link
Author

OK, build passing, FYI I am currently using this in prod, working well, I just want to get rid of the bloodhound fork in my app asap :)

@MichaelXavier
Copy link
Collaborator

LGTM 👍 , @bitemyapp ?

@bitemyapp
Copy link
Owner

Has a test, looks pretty compact. I'll merge.

@bitemyapp bitemyapp merged commit bab3565 into bitemyapp:master Mar 23, 2017
@shmish111
Copy link
Author

Thanks guys, @bitemyapp when will the next version be released to hackage?

@bitemyapp
Copy link
Owner

@shmish111 when either myself or @MichaelXavier feel like it. What's the rush? You can add bab3565 to your stack.yaml.

@shmish111
Copy link
Author

@bitemyapp I did not know you could do that, it's pretty cool.

@shmish111
Copy link
Author

@bitemyapp using a git location is bloody hell, stack wants to recompile all the time for no apparent reason and bloodhound is slooooow at compiling. A release would be very much appreciated as it would make our lives so much more pleasant :-)

@bitemyapp
Copy link
Owner

bitemyapp commented Apr 18, 2017

@shmish111 mark it extra-dep: true

This won't be the last library you'll have a git dep on if you're using Haskell at work. Might as well learn how to make it work.

@shmish111
Copy link
Author

@bitemyapp extra-dep: true doesn't always work, there are some situations where it rebuilds bloodhound and we can't work out when or why but it's fairly often in our development workflow, then we have to https://xkcd.com/303/. It just so happens that bloodhound is a library that takes a long time to compile so it's bad luck on our part but a new release to hackage would solve that. Is there any reason not to?

@bitemyapp
Copy link
Owner

extra-dep: true doesn't always work

Could you elaborate or provide an example? Sounds like something that should get filed as a bug on commercialhaskell/stack too.

@MichaelXavier
Copy link
Collaborator

I should have some time today to put together a changelog and cut a release.

@bitemyapp
Copy link
Owner

@MichaelXavier I'll get it, I want to take care of #180 anyway.

@bitemyapp
Copy link
Owner

http://hackage.haskell.org/package/bloodhound 0.14.0.0 is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants