[ANDR] Adding linker flags to only android platform #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murki
approved these changes
Jan 23, 2025
platform/jvm/BUILD.bazel
Outdated
| ] + select({ | ||
| "@platforms//os:android": ["-Wl,--retain-symbols-file=$(location :jni_symbols.lds)"], | ||
| "@platforms//os:android": ["-Wl,-z,max-page-size=16384,--retain-symbols-file=$(location :jni_symbols.lds)"], |
There was a problem hiding this comment.
this should work, the best way to test this still works would be not to test before/after the pr changes but with and without this flag
|
also for testing this shouldn't affect the gradle test app (that flag is set somewhere else) but only bazel |
murki
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Potential fix for building issues on previous 0.16.9 attempt (see previous failure on https://github.com/bitdriftlabs/capture-sdk/actions/runs/12916680190/job/36022967272)
Test plan
Will follow similar steps listed on prior PR's description #173
Check that Android test app is https://developer.android.com/guide/practices/page-sizes