Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooling] Migrate bazel to bzlmod and update all rules #175

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Conversation

murki
Copy link
Contributor

@murki murki commented Jan 9, 2025

@murki murki mentioned this pull request Jan 9, 2025
@Reflejo Reflejo force-pushed the murki/upgrade-bazel branch from b97833d to 8dc97bf Compare January 14, 2025 05:16
@Reflejo Reflejo changed the title [tooling] Upgrade bazel to 7.4.1 [tooling] Migrate bazel to bzlmod and update all rules Jan 14, 2025
@Reflejo Reflejo force-pushed the murki/upgrade-bazel branch from 8dc97bf to 8a000ca Compare January 14, 2025 05:29
@Reflejo Reflejo marked this pull request as ready for review January 14, 2025 05:30
@Reflejo Reflejo force-pushed the murki/upgrade-bazel branch 3 times, most recently from 17babc2 to ac49b0f Compare January 14, 2025 06:49
@Reflejo Reflejo force-pushed the murki/upgrade-bazel branch from ac49b0f to f90af14 Compare January 14, 2025 07:42
@@ -1,18 +1,18 @@
[versions]
androidBenchkmarkPlugin = "1.2.4"
androidGradlePlugin = "8.2.2" # have to pin to this version due to 8.3.x breaking our lint https://issuetracker.google.com/issues/332755363
androidGradlePlugin = "8.8.0" # have to pin to this version due to 8.3.x breaking our lint https://issuetracker.google.com/issues/332755363
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice they literally released the 8.8 stable version with the fix we needed last week

@murki murki merged commit 83b5111 into main Jan 15, 2025
15 checks passed
@murki murki deleted the murki/upgrade-bazel branch January 15, 2025 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants