-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tooling] Migrate bazel to bzlmod and update all rules #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Reflejo
force-pushed
the
murki/upgrade-bazel
branch
from
January 14, 2025 05:16
b97833d
to
8dc97bf
Compare
Reflejo
changed the title
[tooling] Upgrade bazel to 7.4.1
[tooling] Migrate bazel to bzlmod and update all rules
Jan 14, 2025
Reflejo
force-pushed
the
murki/upgrade-bazel
branch
from
January 14, 2025 05:29
8dc97bf
to
8a000ca
Compare
Reflejo
force-pushed
the
murki/upgrade-bazel
branch
3 times, most recently
from
January 14, 2025 06:49
17babc2
to
ac49b0f
Compare
Reflejo
force-pushed
the
murki/upgrade-bazel
branch
from
January 14, 2025 07:42
ac49b0f
to
f90af14
Compare
murki
commented
Jan 15, 2025
@@ -1,18 +1,18 @@ | |||
[versions] | |||
androidBenchkmarkPlugin = "1.2.4" | |||
androidGradlePlugin = "8.2.2" # have to pin to this version due to 8.3.x breaking our lint https://issuetracker.google.com/issues/332755363 | |||
androidGradlePlugin = "8.8.0" # have to pin to this version due to 8.3.x breaking our lint https://issuetracker.google.com/issues/332755363 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice they literally released the 8.8 stable version with the fix we needed last week
Reflejo
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic smoke testing
on gradle-test-app: https://timeline.bitdrift.dev/session/48da6cef-1583-49b1-adcc-df2822b88999
on bazel hello world app: https://timeline.bitdrift.dev/session/958510ec-8bd1-4c3c-bc25-a0796affde87