Fixed I2C delay bug #123
Merged
Fixed I2C delay bug #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This delay bug was two-fold: 1. Wrong loop delay - The loop delay was (I assume) set for the CF1, and not updated for the CF2. The CF2 runs these loops ~3.5x faster, so the delays were much shorter than expected. I'm not sure if this was a problem, but things seem to be more robust after this change. - The new loop speeds were timed using the DWT->CYCCNT to count clock cycles. 2. Overflow caused hangs - For some reason, it occasionally occurred that the delay variable would (due to it being a uint32_t and being decremented) underflow, wrapping to the maximum value. - The loop was changed to increment the value and terminate on all values greater than the target, rather than only on 0. Signed-off-by: Mike Hamer <[email protected]>
Signed-off-by: Mike Hamer <[email protected]>
|
Looks good and tested. I merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delay bug was two-fold:
i2cdev.h) set for the CF1, and not updated for the CF2. The CF2 runs these loops ~3.5x faster, so the delays were much shorter than expected. I'm not sure if this was a problem, but things seem to be more robust after this change.Signed-off-by: Mike Hamer [email protected]