Always generate version information #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ataffanel
reviewed
Feb 1, 2023
| @@ -45,4 +45,3 @@ build/ | |||
| **/*.cmd | |||
| **/*.a | |||
| *.elf | |||
| src/utils/src/version_gen.c | |||
There was a problem hiding this comment.
Why is the version file removed from .gitignore? It likely should not be committed.
There was a problem hiding this comment.
The path to the generated file is build/src/utils/src/version_gen.c, that is not in the /src dir which means that it is already ignored by the build/ entry in .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces re-generation of the version_gen.c file when the firmware is built. Currently it is not always built which leads to invalid version information in the console log when a Crazyflie is booted.
Fixes #1049