Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python wheel build of the python binding #1184

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Fix python wheel build of the python binding #1184

merged 3 commits into from
Feb 20, 2023

Conversation

ataffanel
Copy link
Member

So far, generating a python wheel was not functional because it was missing the cffirmware.py file/module.

This PR fixes it and add a python_wheel Make target to make it easier to build the wheel. Building the python wheel now only requires calling the tools/build/python_wheel script.

@ataffanel
Copy link
Member Author

This is a required step for issue #1067

krichardsson
krichardsson suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@krichardsson krichardsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
I would suggest to move the python_wheel script out of the tools/build directory and put it in a new one, something like tools/python_bindings or similar, as it can not be run from the toolbelt.

krichardsson
krichardsson approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@krichardsson krichardsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@krichardsson krichardsson merged commit a46e488 into master Feb 20, 2023
@krichardsson krichardsson deleted the ataffanel/fix-python-wheel branch February 20, 2023 12:09
@krichardsson krichardsson added this to the 2023.02 milestone Feb 21, 2023
@knmcguire knmcguire mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krichardsson krichardsson krichardsson approved these changes

@knmcguire knmcguire Awaiting requested review from knmcguire

@whoenig whoenig Awaiting requested review from whoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.02
Development

Successfully merging this pull request may close these issues.
2 participants
@ataffanel @krichardsson