Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #286

Closed
whoenig opened this issue Jan 26, 2018 · 1 comment
Closed

Build error #286

whoenig opened this issue Jan 26, 2018 · 1 comment
Milestone

Comments

@whoenig
Copy link
Contributor

whoenig commented Jan 26, 2018

Building the latest master version breaks the build using arm-none-eabi-gcc 6.3.1 20170620 on Ubuntu 16.04:

src/utils/src/eprintf.c: In function 'evprintf':
src/utils/src/eprintf.c:232:11: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
           if (isdigit((unsigned)*fmt))
           ^~
src/utils/src/eprintf.c:234:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
             fmt++;
             ^~~

This code was changed/introduced about 5 days ago, see https://github.com/bitcraze/crazyflie-firmware/blame/master/src/utils/src/eprintf.c#L232-L234.

Also, what compiler version is the travis cl using? It should have caught the problem.

@ataffanel
Copy link
Member

Hi,
This has been fixed this morning in 26a78f8 and we are updating the docker builder (used in travis) to use the latest arm-none-eabi. Currently travis is using 2016Q2 and this error is found by 2017Q4. It seems that GCC got much better at static analysis lately.

@krichardsson krichardsson added this to the next-version milestone Oct 17, 2018
cafeciaojoe pushed a commit to cafeciaojoe/crazyflie-firmware that referenced this issue Sep 27, 2024
cafeciaojoe pushed a commit to cafeciaojoe/crazyflie-firmware that referenced this issue Sep 27, 2024
…(support for CF1)

Fixed similar problem for LED ring memory also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants