Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed line endings appearing in new commits. #216

Closed
JGSuw opened this issue Apr 11, 2017 · 1 comment
Closed

Mixed line endings appearing in new commits. #216

JGSuw opened this issue Apr 11, 2017 · 1 comment
Milestone

Comments

@JGSuw
Copy link
Contributor

JGSuw commented Apr 11, 2017

I'm seeing carriage returns showing up in places where they don't belong in recent commits, which will certainly lead to spurious diffs in future pull requests. Perhaps a repository .gitattributes file can be used to correct this issue in the future. Also, it may be worth adding a small section to the readme informing Windows contributors of the CRLF vs LF issue, as they may want to config their git to checkout as-is and commit unix-style in the future. At least they should just be aware of the issue.

@ataffanel
Copy link
Member

Hi, this sounds like a good idea. So do I understand well that if we add a .gitattribute file git will transparently handle the conversion during commit?

For windows people, I think the line ending setting is a question during installation, so it might not be necessary to repeat it in our readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants