-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change API of kalman tdoa estimator #163
Comments
This change makes sense, given the current EKF implementation. When I initially wrote the EKF the TDoA skew was part of the main state (instead of tracked separately), in which case its covariances with other states were non zero. To make the EKF more generic, I removed skew from the main state and tracked it separately (equivalent to assuming 0 covariance with other states). Given the current implementation, tracking skew as part of the lpsTdoaTag makes sense, and puts it closer to where it logically belongs (since it is an implementation detail of the TDoA). If this has further benefits (eg. simplifying dealing with the DW1000-specific clock wrapping), then that's only more reason to make this change. This change won't drastically affect things on my side. |
Excellent! Then this sounds like the way forward Thanks! On Fri, Nov 18, 2016 at 9:18 PM Mike Hamer [email protected] wrote:
|
Now uses difference in distance instead of absolute times.
The API change has been pushed but now the input to the EKF is not time anymore but the difference of distance between two anchors. Then it seems that calling it TDoA maybe does make less sense. Can you think of a better name? |
I have been looking at integrating the lpsTdoaTag.c with estimator_kalman.c. My first approach was to adapt the data sent from lpsTdoaTag.c to the estimator to the API of the estimator. When looking at the code in the estimator, I think it makes more sense to do it the other way around and modify the estimator API instead.
I propose to pass the difference of distance (or in ticks) to two anchors instead of absolute time.
Benefits seems to be:
Also, as this would change the API, does it causes problems for anyone else? @mikehamer are you using it for your system?
I have made a spike to try it out in the lab (5aca487) and it seems to work! As I lack full understanding of kalman filters it would be awesome if someone would like to sanity check the changes.
Any input on this is appreciated!
The text was updated successfully, but these errors were encountered: