P2SH/P2WSH payments .network should use .redeem.network if undefined #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Sep 26, 2018
| @@ -59,7 +59,11 @@ function p2wsh (a, opts) { | |||
| }) | |||
| const _rchunks = lazy.value(function () { return bscript.decompile(a.redeem.input) }) | |||
|
|
|||
| const network = a.network || BITCOIN_NETWORK | |||
| let network = a.network | |||
| if (!network) { | |||
There was a problem hiding this comment.
I suppose this could be a.network || (a.redeem && a.redeem.network) || BITCOIN_NETWORK
dcousens
commented
Sep 26, 2018
| @@ -96,10 +96,11 @@ function preform (x) { | |||
| if (x.pubkeys) x.pubkeys = x.pubkeys.map(fromHex) | |||
| if (x.signatures) x.signatures = x.signatures.map(function (y) { return Number.isFinite(y) ? y : Buffer.from(y, 'hex') }) | |||
| if (x.redeem) { | |||
| x.redeem = Object.assign({}, x.redeem) | |||
There was a problem hiding this comment.
this was frustrating
|
LGTM |
junderw
approved these changes
Sep 26, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
networknow favours that which is defined...