Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script isCanonical* refactor/renames #1094

Merged
merged 3 commits into from
Jun 21, 2018
Merged

script isCanonical* refactor/renames #1094

merged 3 commits into from
Jun 21, 2018

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented Jun 5, 2018 •
edited
Loading

Misleading otherwise

@dcousens dcousens added this to the 4.0.0 milestone Jun 5, 2018
@dcousens
Copy link
Contributor Author

dcousens commented Jun 5, 2018

Alternatively, we could probably remove isCanonicalPubkey in favour of users using the ECC library?

@dcousens dcousens merged commit e50679d into master Jun 21, 2018
@dcousens
Copy link
Contributor Author

@junderw post-review ACK appreciated

@dcousens dcousens deleted the canon branch June 21, 2018 02:45
@dcousens dcousens modified the milestone: 4.0.0 Jul 17, 2018
@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change refactor
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dcousens