Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.rs to use structopt and add missing docs, add TODOs for other missing_docs #203

Closed
wants to merge 8 commits into from

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 1, 2020

This PR includes commits from #194 and @RCasatta docs for electrum.rs and esplora.rs.

Partial work for #192.

@@ -373,20 +374,22 @@ struct EsploraGetHistory {
status: EsploraGetHistoryStatus,
}

/// `EsploraHeader` maps the json returned from esplora endpoint `GET /block/:hash`
/// It will be removed when `GET /block/:hash/header` will be deployed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deployed.

@notmandatory
Copy link
Member Author

Splitting this PR into 3 new ones..

@notmandatory notmandatory deleted the missing_docs branch December 24, 2020 04:58
nickfarrow pushed a commit to nickfarrow/bdk that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants