Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typos #1319

Merged
merged 1 commit into from
Feb 4, 2024
Merged

chore: typos #1319

merged 1 commit into from
Feb 4, 2024
+4 −4

Conversation

storopoli
Copy link
Contributor

@storopoli storopoli commented Feb 4, 2024 •
edited
Loading

More caught on by Nix CI in #1257.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@storopoli
chore: typos
8d93fad 
More caught on by Nix CI in bitcoindevkit#1257.
evanlinjin
evanlinjin approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d93fad

@storopoli storopoli mentioned this pull request Feb 4, 2024
Draft
8 tasks
@notmandatory notmandatory added this to the 1.0.0 milestone Feb 4, 2024
notmandatory
notmandatory approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d93fad

@notmandatory notmandatory merged commit d8f74dc into bitcoindevkit:master Feb 4, 2024
12 checks passed
@storopoli storopoli deleted the js/typos branch February 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@storopoli storopoli

Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@storopoli @notmandatory @evanlinjin