Further improve unconfirmed tx conflict resolution #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing tests are commented out. Signed-off-by: Wei Chen <[email protected]>
`TxGraph::try_get_chain_position` traverses ancestors so we do not skip conflicts. fix(chain): add check for ancestor tx conflicts in `TxGraph` Signed-off-by: Wei Chen <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
LagginTimes
force-pushed
the
same_last_seen
branch
from
c91aa1c to
a6420ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1102. If a conflicting tx has the same
last_seen, then we check if the conflicting tx has a higher absolute fee and fee rate. If fee rates cannot be determined, then we fall back to lexicographical sorting of txids.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing