-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bdk to alpha 7 #468
Bump bdk to alpha 7 #468
Conversation
WalkthroughThe recent update introduces a new method and variant named Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The failure of the Swift tests maybe look like what is referenced in this issue.
|
8a43076
to
bf39421
Compare
ACK bf39421 changing from |
No changing it didn't solve it unfortunately (but makes more sense so I'm happy it didn't). We're still getting linker errors for iOS when attempting to use the reqwest dependency. |
bf39421
to
06fa9d7
Compare
This PR:
2. Finally closes a long-standing comment/issue where we could not use rustls for the async esplora client, preventing us from building for Android. The commit enabling the feature simply enables it, but does not build the async client itself.This is currently causing runtime issues. Will fix in a further PR.Notes to the reviewers
This bump was fairly simple.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing