test: run rpc-generateblock.py even with wallet disabled #23558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariusParvin
force-pushed
the
rpc-generateblock-to-miniwallet
branch
from
a8acd3e to
42ae0cd
Compare
maflcko
reviewed
Nov 20, 2021
DariusParvin
force-pushed
the
rpc-generateblock-to-miniwallet
branch
from
78a72ab to
f38c11b
Compare
maflcko
reviewed
Nov 20, 2021
DariusParvin
force-pushed
the
rpc-generateblock-to-miniwallet
branch
from
a82325d to
d94164b
Compare
|
Thanks, Concept ACK. |
DariusParvin
force-pushed
the
rpc-generateblock-to-miniwallet
branch
from
7686983 to
7c24756
Compare
DariusParvin
force-pushed
the
rpc-generateblock-to-miniwallet
branch
from
7c24756 to
1e86ff7
Compare
mjdietzx
reviewed
Nov 20, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 21, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run rpc_generateblock.py test even when the wallet is disabled, as discussed in #20078.
This PR picked up from where #20808 left off, started by @nginocchio. Since then, there have been many improvements to
MiniWallet, making this PR more straightforward.L23 makes use of
MiniWallet.rescan_utxos()to add the pre-mined block utxos (whenself.setup_clean_chainis not set toTrue), rather than generating new blocks during the test.