test: use MiniWallet for make_utxo helper in feature_rbf.py #22998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in order to prepare the make_utxo helper to use MiniWallet, which only supports creating transactions with single inputs, i.e. we need to create amounts small enough to be funded by coinbase transactions (50 BTC).
This is done in order to prepare the make_utxo helper to use MiniWallet, which only supports creating transactions with single inputs, i.e. we need to create amounts small enough to be funded by coinbase transactions (50 BTC).
theStack
force-pushed
the
202109-test-use_miniwallet_for_make_utxo
branch
from
63b96c1 to
f680d27
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 17, 2021
|
concept ACK commenting test_rpc subtestchanges on test_rpc proposed in #23052 |
maflcko
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
review ACK f680d27 🦐
Show signature and timestamp
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
review ACK f680d27155374de658d40db0ba40460919aa1ba2 🦐
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjbcgwAkRTDpqwf/UETFI6ocdBFK2PZqYgMFszvH/UuC2h2MvgeZGV8ZnBl8BKQ
4wyWuZJSY13QCjVbaUeF0jqzMw8mJd1KUMaAw3nHP4lasGpuOxhhP5l0xyK6UJB1
1inOWwb1GEB2p5Bhd6m0q4ucSo3da5OBdE1OO+GAmOBaEZE5AKvExIxnZEd74A1E
yL1K6vzw+ajJaofIOm/AkOe9x7mrHC4ilqOrQVf4UHZ3YG9np9BVDx4srCbyaXWr
OHeTY9EJx38XSLJooQs9Ap+7zexx8jXv6vqsJuR+deZoq83xqo4WaInrXsCFDiux
yFccruXkXlIh47BEkwSKRBI/7avqiNvNoVKiQGHhFbn2km9YIkEJRASfCuB5kxca
MM6xt6GfvSQc7IiUiN3DaACJH1ut5GALVX0KiJRw1Y+wYlWJjqwoG0TgJUezXaUy
5+oP93maZNRsWses07raJXmJ8j2hSYcvPmfGeOKWDgDpEXJfk/r7b/MZFPBzOG8q
kqgKZP7P
=4DjW
-----END PGP SIGNATURE-----
Timestamp of file with hash 8c9f3fb0e7a45d86ca12d77967ff62c2f410f3766b9ea0920fb291caba583a61 -
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 21, 2021
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 29, 2021
cfdb6ba test: use MiniWallet for p2p_filter.py (Sebastian Falbesoner) 6fc2cd3 test: introduce helper to create random P2WPKH scriptPubKeys (Sebastian Falbesoner) aa26797 test: MiniWallet: add `send_to` method to create arbitrary txouts (Sebastian Falbesoner) Pull request description: This PR enables one more of the non-wallet functional tests (p2p_filter.py) to be run even with the Bitcoin Core wallet disabled by using the MiniWallet instead, as proposed in bitcoin#20078. For this purpose, a MiniWallet method `send_to` is introduced first, which allows to create arbitrary outputs (scriptPubKey/amount). Note that the implementation for this is already present in feature_rbf.py (recently added in PR bitcoin#22998), i.e. it is simply moved to the MiniWallet interface. ACKs for top commit: laanwj: Code review ACK cfdb6ba Tree-SHA512: 13b063631f0d7af065b7757cfe8b47c9be6cb9850ac5db2968a2bba4f5a18cdc9f89173a9b03971545356225082042f5fdbe49d3036027d18e8b7eb042d04f5e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to further increase MiniWallet usage in the functional test feature_rbf.py by using it in the
make_utxo(...)helper, which is the only part that needs a wallet for most sub-tests. In order to do that, the amounts for the utxos have to be scaled down in two sub-tests first (test_doublespend_chainandtest_doublespend_tree, see first two commits), since we need amounts passed tomake_utxothan can be funded by only one input. For creating UTXOs with a value of 50 BTC, we'd need to implement a method for consolidating multiple utxos into one first, which seems to be overkill.Note that after this PR's change, there is only one sub-test left (
test_rpc) that needs the wallet compiled into bitcoind.