windres: use PACKAGE_VERSION rather than building more version numbers #22724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than defining more strings, reuse PACKAGE_VERSION, which is already available. We already use PACKAGE_VERSION for `ProductVersion` and `FileVersion` in setup.nsi.
|
cr ACK f12fbad |
|
Guix build: 66e4e416537e60bc72502db325eca9f7c122193f85ae50602aab060987b223b2 guix-build-f12fbad5a185/output/aarch64-linux-gnu/SHA256SUMS.part
c0896cf12a2feb9264627147e9dcd7c614685a6335dd2ebd8e67179769896ed3 guix-build-f12fbad5a185/output/aarch64-linux-gnu/bitcoin-f12fbad5a185-aarch64-linux-gnu-debug.tar.gz
9bb50b554f829c2ceb3d8d8e3475b1a8bafad9ebf291fe79b62823ed2075236a guix-build-f12fbad5a185/output/aarch64-linux-gnu/bitcoin-f12fbad5a185-aarch64-linux-gnu.tar.gz
88ccebd7030c1dd9ecc38303c97704031cff55379cfe07fed7b950870126d2c6 guix-build-f12fbad5a185/output/arm-linux-gnueabihf/SHA256SUMS.part
9bd87c508c4f1a9275fa423b04fc7e6313a8e7345c6bb00c1277447a48975f3b guix-build-f12fbad5a185/output/arm-linux-gnueabihf/bitcoin-f12fbad5a185-arm-linux-gnueabihf-debug.tar.gz
b9ce8908ff4386991b3a717414bb0430453097f5a3f093be22c898f2cae432d6 guix-build-f12fbad5a185/output/arm-linux-gnueabihf/bitcoin-f12fbad5a185-arm-linux-gnueabihf.tar.gz
4116a4f41fa29c98f06aec62a2978f30ebc494c5914bb3e5224907a56ae88b54 guix-build-f12fbad5a185/output/dist-archive/bitcoin-f12fbad5a185.tar.gz
e09b0641648c4560b1b90508aca2fa49f2e65a9897eb8fcdadf681d1327f8b61 guix-build-f12fbad5a185/output/powerpc64-linux-gnu/SHA256SUMS.part
6c590d736246098c1516fc6093e396d9737dc0a28eb0b23f4df5d4ee84ab23c7 guix-build-f12fbad5a185/output/powerpc64-linux-gnu/bitcoin-f12fbad5a185-powerpc64-linux-gnu-debug.tar.gz
809d49cc29157e0a9de33696019a6bda5f6bdf759757da39c191ec23fe5c3005 guix-build-f12fbad5a185/output/powerpc64-linux-gnu/bitcoin-f12fbad5a185-powerpc64-linux-gnu.tar.gz
925b28b7c597efda7f6fd03b9a91e6bccf20f65936af8f6225f41b87b76ce06a guix-build-f12fbad5a185/output/powerpc64le-linux-gnu/SHA256SUMS.part
3f7e26e354b12c9cd6322763425c2971328d6c85f6170cfd6134f18f72b55f6a guix-build-f12fbad5a185/output/powerpc64le-linux-gnu/bitcoin-f12fbad5a185-powerpc64le-linux-gnu-debug.tar.gz
43ac2b08ad5b5e64ff66c80a552f04f6ea8c63f61dd1f0aa7c3c29c401dca05f guix-build-f12fbad5a185/output/powerpc64le-linux-gnu/bitcoin-f12fbad5a185-powerpc64le-linux-gnu.tar.gz
e7f82e7bad1daf60d12dbc42b2fac49f4c7062e4c9b39cc8f7f6764caf8ca975 guix-build-f12fbad5a185/output/riscv64-linux-gnu/SHA256SUMS.part
fd2026aa9b0bc274c63f1b6194b05b9e11572d9e9b859f75ede9dc2a13002d05 guix-build-f12fbad5a185/output/riscv64-linux-gnu/bitcoin-f12fbad5a185-riscv64-linux-gnu-debug.tar.gz
294c81e9b2b8e44c7a5bb71f70ac63972fdc097fed6d2f6d9c453801e170516a guix-build-f12fbad5a185/output/riscv64-linux-gnu/bitcoin-f12fbad5a185-riscv64-linux-gnu.tar.gz
2d888256ea1910034d89f7c0e1121dcabb4c1a3919fb35e3c108d3b677cdb472 guix-build-f12fbad5a185/output/x86_64-apple-darwin18/SHA256SUMS.part
56a9a651d0349a19e24e85c4e4e17f83c7e02c0275de1231e404fae4760c2014 guix-build-f12fbad5a185/output/x86_64-apple-darwin18/bitcoin-f12fbad5a185-osx-unsigned.dmg
1849d8045c19111291ecce2e5880ae0a9d1e8a593a55386eb91fd797f0c36f0c guix-build-f12fbad5a185/output/x86_64-apple-darwin18/bitcoin-f12fbad5a185-osx-unsigned.tar.gz
e4174792350605398f6a72c6a6408b3688537678c6c16a08e8109b751f70fe24 guix-build-f12fbad5a185/output/x86_64-apple-darwin18/bitcoin-f12fbad5a185-osx64.tar.gz
eba8443129e216633b55eaeced25b8eebb0993b68515140aae21be7c6fa25706 guix-build-f12fbad5a185/output/x86_64-linux-gnu/SHA256SUMS.part
05f8fcfafd126a6542ff1ca6e0551284afcd748278426e47513c14f3fc45a989 guix-build-f12fbad5a185/output/x86_64-linux-gnu/bitcoin-f12fbad5a185-x86_64-linux-gnu-debug.tar.gz
0ccff593351dece86321fb2fd6c2f2e4d48efab133ac7e7c45b966a181a6ffe1 guix-build-f12fbad5a185/output/x86_64-linux-gnu/bitcoin-f12fbad5a185-x86_64-linux-gnu.tar.gz
b3f8cf3fde2ddbcb455fa0568ad299e837fd293cb43cfdd488428587c5acd8b3 guix-build-f12fbad5a185/output/x86_64-w64-mingw32/SHA256SUMS.part
c9c24a1925c615f92ba0c7d9166c27c8688e4b3d2d27fb42e53084dc752877e2 guix-build-f12fbad5a185/output/x86_64-w64-mingw32/bitcoin-f12fbad5a185-win-unsigned.tar.gz
fd2bba70034e5a838395228b1b951dfed8d3431e9a13baa31371cc1021b0a67e guix-build-f12fbad5a185/output/x86_64-w64-mingw32/bitcoin-f12fbad5a185-win64-debug.zip
0803c10e2dae3db531c7b4c01e8abeb58f40eec03a89f2c14d8b043fd9c6a77f guix-build-f12fbad5a185/output/x86_64-w64-mingw32/bitcoin-f12fbad5a185-win64-setup-unsigned.exe
8e4e07bfcf6e4b3bec5840d2f73a3e952253686e2612f304f54ff3408a6bcc87 guix-build-f12fbad5a185/output/x86_64-w64-mingw32/bitcoin-f12fbad5a185-win64.zip |
|
Looking at the output in Code review ACK f12fbad |
|
Contributing GUIX hashes, mine match @fanquake |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than defining more strings, reuse PACKAGE_VERSION, which is already available.
We also already use PACKAGE_VERSION for
ProductVersionandFileVersionin setup.nsi.