Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore English translation option #17886

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

achow101
Copy link
Member

@achow101 achow101 commented Jan 7, 2020

It was reported on Bitcointalk that the normal English language option was lost in 0.19. This PR restores it. For some reason it was removed during the last periodic translation update.

@fanquake fanquake added the GUI label Jan 7, 2020
@fanquake
Copy link
Member

fanquake commented Jan 7, 2020

@fanquake fanquake requested a review from laanwj January 7, 2020 04:06
@achow101
Copy link
Member Author

achow101 commented Jan 7, 2020

Looks like it's probably because the all_ts_files() function in update-translations.py explicitly ignores the bitcoin_en.ts file.

@laanwj
Copy link
Member

laanwj commented Jan 8, 2020

This was definitely overlooked. These files are auto-generated by update-translations.py, which excludes the English translation. It shouldn't, for that purpose.

@laanwj
Copy link
Member

laanwj commented Jan 8, 2020

This PR is not strictly needed as the next periodic translation update (with bitcoin-core/bitcoin-maintainer-tools#50) will restore the files.

But maybe it's useful for testing in the mean-time (as there are no translations for master) so
ACK 63bf06a

I will simply do a translations update for the 0.19 branch.

laanwj added a commit that referenced this pull request Jan 8, 2020
Brings back `bitcoin_en` which was accidentally removed last time (see #17886).

Tree-SHA512: a4aaa6f22e9ad3e87952f2a87829d675158cb26ed1fe61ef8e62646c22e21ccc0dec0f890b726f8adb76d7609e0274af8574b67201d30eff941cb60b1b76ff8c
laanwj added a commit that referenced this pull request Jan 8, 2020
63bf06a Restore English translation option (Andrew Chow)

Pull request description:

  It was [reported on Bitcointalk](https://bitcointalk.org/index.php?topic=5204167.msg53540137#msg53540137) that the normal English language option was lost in 0.19. This PR restores it. For some reason it was removed during the last periodic translation update.

ACKs for top commit:
  laanwj:
    ACK 63bf06a

Tree-SHA512: 94c7c7407f69e8df91fbbd8f8c5e3e8e031d308b72d775a00bcee564f2762a92f65c140029ce805faccdb767a25c0e222a396708c6ce29a5882bab939a45b772
@laanwj laanwj merged commit 63bf06a into bitcoin:master Jan 8, 2020
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Jan 12, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants