Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add deserialization fuzzing harnesses #17051

Merged
merged 2 commits into from
Dec 6, 2019
Merged

tests: Add deserialization fuzzing harnesses #17051

merged 2 commits into from
Dec 6, 2019

Conversation

practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Oct 4, 2019 •
edited
Loading

Add deserialization fuzzing harnesses.

Testing this PR

Run:

$ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
$ make
$ contrib/devtools/test_fuzzing_harnesses.sh 'addr_info|block_file_info|block_filter|block_header|ext_key|ext_pub_key|fee_rate|flat_file|key_origin|merkle_block|mutable_transaction|out_point|partial_merkle_tree|partially_signed_transaction|prefilled_transaction|psbt_input|psbt_output|pub_key|script_deserialize|sub_net|tx_in' 10

test_fuzzing_harnesses.sh can be found in PR #17000.

@fanquake fanquake added the Tests label Oct 4, 2019
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 4, 2019 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17229 (tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions by practicalswift)
  • #17225 (tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. by practicalswift)
  • #17109 (tests: Add fuzzing harness for various functions consuming only integrals by practicalswift)
  • #17093 (tests: Add fuzzing harness for various CTx{In,Out} related functions by practicalswift)
  • #17071 (tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions by practicalswift)
  • #17050 (tests: Add fuzzing harnesses for functions parsing scripts, numbers, JSON and HD keypaths (bip32) by practicalswift)
  • #10785 (Serialization improvements by sipa)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift practicalswift force-pushed the fuzzers-deserialize branch 2 times, most recently from 71fb44e to 9e11f4e Compare October 10, 2019 14:44
@practicalswift practicalswift force-pushed the fuzzers-deserialize branch 4 times, most recently from 4b06bf7 to 8cd9cb5 Compare October 11, 2019 13:47
@practicalswift practicalswift mentioned this pull request Oct 13, 2019
Closed
@practicalswift practicalswift mentioned this pull request Oct 23, 2019
Merged
@practicalswift practicalswift force-pushed the fuzzers-deserialize branch 2 times, most recently from 61d702f to 4d350b7 Compare October 24, 2019 21:53
@practicalswift
Copy link
Contributor Author

Rebased!

@practicalswift
Copy link
Contributor Author

Rebased!

@practicalswift practicalswift mentioned this pull request Oct 31, 2019
Closed
@practicalswift
Copy link
Contributor Author

Rebased! :)

@practicalswift
Copy link
Contributor Author

Closing due to lack of interest

@laanwj
Copy link
Member

laanwj commented Dec 6, 2019 •
edited
Loading

This does zero changes to non-fuzzer code, we should probably just merge this.

But this is what I meant when I commented on it earlier, with it being better to group things in one PR, if you keep opening similar-sounding PRs, reviewers are going to pay less attention to them.

@practicalswift
Copy link
Contributor Author

@laanwj @MarcoFalke

OK, I'm re-opening for now - feel free to merge :)

I'm fuzzing my own custom fuzzing repo continuously using a very large fuzzing farm, but it sure would be nice to have this upstreamed to keep things simple and so that others could benefit from the code as well :)

@practicalswift practicalswift reopened this Dec 6, 2019
@laanwj
Copy link
Member

laanwj commented Dec 6, 2019

thanks, ACK 897849d

laanwj added a commit that referenced this pull request Dec 6, 2019
@laanwj
Merge #17051: tests: Add deserialization fuzzing harnesses
cb11324 
897849d tests: Add deserialization fuzzing harnesses (practicalswift)
16f0a18 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift)

Pull request description:

  Add deserialization fuzzing harnesses.

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
  $ make
  $ contrib/devtools/test_fuzzing_harnesses.sh 'addr_info|block_file_info|block_filter|block_header|ext_key|ext_pub_key|fee_rate|flat_file|key_origin|merkle_block|mutable_transaction|out_point|partial_merkle_tree|partially_signed_transaction|prefilled_transaction|psbt_input|psbt_output|pub_key|script_deserialize|sub_net|tx_in' 10
  ```

  `test_fuzzing_harnesses.sh` can be found in PR #17000.

ACKs for top commit:
  laanwj:
    thanks, ACK 897849d

Tree-SHA512: 5a270a3002cc23b725f7b35476a43777b2b00b4d089cc006372e2fcc7afa430afaa3c1430f778ae08fc53dd85a13e7bd2fab0449c319f676423226e189a417f6
@laanwj laanwj merged commit 897849d into bitcoin:master Dec 6, 2019
jonatack
jonatack reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 897849d

Light code review, built, ran test_fuzzing_harnesses.sh. Output in this gist.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 6, 2019
@laanwj
Merge bitcoin#17051: tests: Add deserialization fuzzing harnesses
3e39c95 
897849d tests: Add deserialization fuzzing harnesses (practicalswift)
16f0a18 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift)

Pull request description:

  Add deserialization fuzzing harnesses.

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
  $ make
  $ contrib/devtools/test_fuzzing_harnesses.sh 'addr_info|block_file_info|block_filter|block_header|ext_key|ext_pub_key|fee_rate|flat_file|key_origin|merkle_block|mutable_transaction|out_point|partial_merkle_tree|partially_signed_transaction|prefilled_transaction|psbt_input|psbt_output|pub_key|script_deserialize|sub_net|tx_in' 10
  ```

  `test_fuzzing_harnesses.sh` can be found in PR bitcoin#17000.

ACKs for top commit:
  laanwj:
    thanks, ACK 897849d

Tree-SHA512: 5a270a3002cc23b725f7b35476a43777b2b00b4d089cc006372e2fcc7afa430afaa3c1430f778ae08fc53dd85a13e7bd2fab0449c319f676423226e189a417f6
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jul 17, 2020
@laanwj @majcosta
[backport#17051] tests: Add deserialization fuzzing harnesses
27e9ca8 
Summary:
897849d8c225045f0dd3a2fe99b5d69bdf84b4e2 tests: Add deserialization fuzzing harnesses (practicalswift)
16f0a186dcee563bb1000e1ffc51da87e7623bc6 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift)

Pull request description:

  Add deserialization fuzzing harnesses.

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
  $ make
  $ contrib/devtools/test_fuzzing_harnesses.sh 'addr_info|block_file_info|block_filter|block_header|ext_key|ext_pub_key|fee_rate|flat_file|key_origin|merkle_block|mutable_transaction|out_point|partial_merkle_tree|partially_signed_transaction|prefilled_transaction|psbt_input|psbt_output|pub_key|script_deserialize|sub_net|tx_in' 10
  ```

  `test_fuzzing_harnesses.sh` can be found in PR #17000.

---

Depends on D6945

Backport of Core [[bitcoin/bitcoin#17051 | PR17051]]

Test Plan:
  cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer;undefined" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
  ninja bitcoin-fuzzers link-fuzz-test_runner.py
  ./test/fuzz/test_runner.py -l DEBUG <path_to_corpus>

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6947
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
@laanwj
Merge bitcoin#17051: tests: Add deserialization fuzzing harnesses
2a85553 
897849d tests: Add deserialization fuzzing harnesses (practicalswift)
16f0a18 tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missing in https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus (practicalswift)

Pull request description:

  Add deserialization fuzzing harnesses.

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined
  $ make
  $ contrib/devtools/test_fuzzing_harnesses.sh 'addr_info|block_file_info|block_filter|block_header|ext_key|ext_pub_key|fee_rate|flat_file|key_origin|merkle_block|mutable_transaction|out_point|partial_merkle_tree|partially_signed_transaction|prefilled_transaction|psbt_input|psbt_output|pub_key|script_deserialize|sub_net|tx_in' 10
  ```

  `test_fuzzing_harnesses.sh` can be found in PR bitcoin#17000.

ACKs for top commit:
  laanwj:
    thanks, ACK 897849d

Tree-SHA512: 5a270a3002cc23b725f7b35476a43777b2b00b4d089cc006372e2fcc7afa430afaa3c1430f778ae08fc53dd85a13e7bd2fab0449c319f676423226e189a417f6
@furszy furszy mentioned this pull request Mar 24, 2021
Merged
@practicalswift practicalswift deleted the fuzzers-deserialize branch April 10, 2021 19:39
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request May 28, 2021
@random-zebra
Merge #2252: Fuzzing framework support
44b5327 
d059544 [Build] fuzz target, change LIBBITCOIN_ZEROCOIN link order. (furszy)
2396e6b [fuzz] Add ContextualCheckTransaction call to transaction target. (furszy)
f0887a0 Fuzzing documentation "PIVX-fication" (furszy)
9631f46 [doc] add sanitizers documentation in developer-notes.md (furszy)
70a0ace tests: Test serialisation as part of deserialisation fuzzing. Test round-trip equality where possible. Avoid code repetition. (practicalswift)
e1b92b6 ignore new fuzz targets gitignore (furszy)
d058d8c tests: Add deserialization fuzzing harnesses (furszy)
e1f666c tests: Remove TRANSACTION_DESERIALIZE (replaced by transaction fuzzer) (practicalswift)
b5f291c tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions (furszy)
3205871 fuzz: Remove option --export_coverage from test_runner (MarcoFalke)
52693ee fuzz: Add option to merge input dir to test runner (MarcoFalke)
2b4f8aa doc: Remove --disable-ccache from docs (MarcoFalke)
b54b1d6 tests: Improve test runner output in case of target errors (practicalswift)
cd6134f test: Log output even if fuzzer failed (MarcoFalke)
48cd0c8 doc: Improve fuzzing docs for macOS users (Fabian Jahr)
d642b67 [Build] Do not disable wallet when fuzz is enabled. (furszy)
c3447b5 Update doc and CI config (qmma)
1266d3e Disable other targets when enable-fuzz is set (qmma)
f28ac9a build: Allow to configure --with-sanitizers=fuzzer (MarcoFalke)
425742c fuzz: test_runner: Better error message when built with afl (MarcoFalke)
541f442 qa: Add test/fuzz/test_runner.py (MarcoFalke)
89fe5b2 Add missing LIBBITCOIN_ZMQ to test target (furszy)
58dbe79 add fuzzing binaries to gitignore. (furszy)
393a126 fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (MarcoFalke)
a568df5 test: Build fuzz targets into separate executables (furszy)
d5dddde [test] fuzz: make test_one_input return void (MarcoFalke)
2e4ec58 [fuzzing] initialize chain params by default. (furszy)
08d8ebe [tests] Add libFuzzer support. (practicalswift)
84f72da [test] Speed up fuzzing by ~200x when using afl-fuzz (practicalswift)
faf2be6 Init ECC context for test_bitcoin_fuzzy. (Gregory Maxwell)
11150df Make fuzzer actually test CTxOutCompressor (Pieter Wuille)
d6f6a85 doc: Add bare-bones documentation for fuzzing (Wladimir J. van der Laan)
5c3b550 Simple fuzzing framework (pstratem)

Pull request description:

  As the title says, adding fuzzing framework support so we can start getting serious on this area as well.

  Adapted the following PRs:

  * bitcoin#9172.
  * bitcoin#9354.
  * bitcoin#9691.
  * bitcoin#10415.
  * bitcoin#10440.
  * bitcoin#15043.
  * bitcoin#15047.
  * bitcoin#15295.
  * bitcoin#15399 (fabcfa5 only).
  * bitcoin#16338.
  * bitcoin#17051.
  * bitcoin#17076.
  * bitcoin#17225.
  * bitcoin#17942.
  * bitcoin#16236 (only fa35c42).
  * bitcoin#18166 (only f2472f6).
  * bitcoin#18300.
  * And.. probably will go further and continue adapting more PRs..

ACKs for top commit:
  random-zebra:
    utACK d059544 and merging...

Tree-SHA512: c0b05bca47bf99bafd8abf1453c5636fe05df75f16d0e9c750368ea2aed8142f0b28d28af1d23468b8829188412a80fd3b7bdbbda294b940d78aec80c1c7d03a
kwvg added a commit to kwvg/dash that referenced this pull request Aug 2, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
b6583ac
kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
6c8933a
kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
ade8464
kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
569a711
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Aug 6, 2021
@kwvg @PastaPastaPasta
bitcoin#17051: Add deserialization fuzzing harnesses
3758c58
kwvg added a commit to kwvg/dash that referenced this pull request Aug 8, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
bad14f5
kwvg added a commit to kwvg/dash that referenced this pull request Aug 11, 2021
@kwvg
bitcoin#17051: Add deserialization fuzzing harnesses
4e6aca0
5tefan pushed a commit to 5tefan/dash that referenced this pull request Aug 12, 2021
@kwvg @5tefan
bitcoin#17051: Add deserialization fuzzing harnesses
49f8ea5
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 6, 2022
@kwvg @gades
bitcoin#17051: Add deserialization fuzzing harnesses
1f8162d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonatack jonatack jonatack left review comments

@maflcko maflcko maflcko left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@practicalswift @DrahtBot @laanwj @jonatack @maflcko @fanquake