tests_exhaustive: check the result of secp256k1_ecdsa_sign #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In
test_exhaustive_sign
, ifsecp256k1_ecdsa_sign
fails, the signature which is then loaded bysecp256k1_ecdsa_signature_load
is garbage. Exit early with an error when this occurs.By the way, I am wondering whether attribute
SECP256K1_WARN_UNUSED_RESULT
should be added to functionsecp256k1_ecdsa_sign
: as (according to the documentation of this function) the nonce generation function may fail, it seems to be a good idea to force callers to check the value returned by this function. What do you think about this?