tests: Initialize random group elements fully #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix add a missing comment.
real-or-random
force-pushed
the
202009-test-ge-inf
branch
from
494d381 to
5738e86
Compare
|
utACK. Looks fine to me. |
|
utACK 5738e86 |
real-or-random
commented
Sep 14, 2020
| @@ -86,6 +86,7 @@ void random_group_element_test(secp256k1_ge *ge) { | |||
| break; | |||
| } | |||
| } while(1); | |||
| ge->infinity = 0; | |||
There was a problem hiding this comment.
Oh, on a second thought, this is not just necessary. secp256k1_ge_set_xo_var (a few lines above) sets infinity to 0.
I was playing around with multiple additional VERIFY_CHECKs when reviewing the schnorrsig PR and I wrongly believed that I found this bug ...
Well whatever, the correct was correct before this PR and it's correct after this PR. If we want, we can reverse this commit in a later PR.
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 28, 2020
Summary: Also fix add a missing comment. This is a backport of secp56k1 [[bitcoin-core/secp256k1#814 | [[bitcoin-core/secp256k1#814 | PR814]]]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7613
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Sep 29, 2020
Summary: Also fix add a missing comment. This is a backport of secp56k1 [[bitcoin-core/secp256k1#814 | [[bitcoin-core/secp256k1#814 | PR814]]]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix add a missing comment.