Document that infinity must not be passed to ecmult_const #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-or-random
force-pushed
the
202008-ecmult-const-noinf
branch
from
1c45145 to
2a45b80
Compare
|
Related to #788. |
|
What happens if you pass in a point at infinity? :) |
|
Ah. Storage type doesn't currently encode infinities so the to precomputed tables have issues. Other than that it looks like it takes a smaller change to fix infinity support, most of which is obviously more correct than not doing it. |
|
Unless I'm mistaken, ecmult isn't constant time with respect to the point input. If so, it could just return infinity in this case. It would be a smaller diff and less weird-surface to handle for future users of the function. |
Oh that's a good point. I took the easy way with constant-timeness in mind but yes, it's constant-time in the scalar only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.