Revert "Merge #620: Install headers automatically" #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in bitcoin-core#625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments.
|
ACK. (following the principle of revert errors eagerly and favor the status quo, if it turns out I'm missing some reason why this wasn't the best solution-- that's fine. We could switch to another solution later). |
gmaxwell
added a commit
that referenced
this pull request
May 24, 2019
662918c Revert "Merge #620: Install headers automatically" (ian) Pull request description: This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in #625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments. Closes #624 Tree-SHA512: 7769ede527ac307bff094603e5974c56b19e41bc2ef55113173d3dbc8e545d6add7ae044753fa0361595e5e7a746d6c8d641f98caa3381b683aa2b61a1742097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 91fae3a, reversing
changes made to 5df77a0.
See discussion in #625
After the change, if we enable any module,
make installfails because of theduplicated files in the command line arguments.
Closes #624