Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases from API
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-or-random
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
utACK
But needs rebase.
I think it's totally fine to remove these now. Would be nice to merge this for the same release as #1639 which is also breaking.
CHANGELOG.md
Outdated
Comment on lines
11
to
13
| - The previously deprecated function aliases `secp256k1_ec_privkey_negate`, `secp256k1_ec_privkey_tweak_add` and | ||
| `secp256k1_ec_privkey_tweak_mul` were removed. The corresponding replacements `secp256k1_ec_seckey_negate`, | ||
| `secp256k1_ec_seckey_tweak_add` and `secp256k1_ec_seckey_tweak_mul` have to be used instead. |
There was a problem hiding this comment.
nit, slightly shorter without loss of information:
Suggested change
| - The previously deprecated function aliases `secp256k1_ec_privkey_negate`, `secp256k1_ec_privkey_tweak_add` and | |
| `secp256k1_ec_privkey_tweak_mul` were removed. The corresponding replacements `secp256k1_ec_seckey_negate`, | |
| `secp256k1_ec_seckey_tweak_add` and `secp256k1_ec_seckey_tweak_mul` have to be used instead. | |
| - Removed previously deprecated function aliases `secp256k1_ec_privkey_negate`, `secp256k1_ec_privkey_tweak_add`, and | |
| `secp256k1_ec_privkey_tweak_mul`. Use `secp256k1_ec_seckey_negate`, | |
| `secp256k1_ec_seckey_tweak_add`, and `secp256k1_ec_seckey_tweak_mul` instead. |
These function aliases have been described as DEPRECATED in the public API docs already many years ago (see bitcoin-core#701, commit 41fc785), and in addition explicit deprecation warnings are shown by the compiler at least since the first official release 0.2.0 (see PR bitcoin-core#1089, commit fc94a2d), so it should be fine to just remove them by now. Co-authored-by: Tim Ruffing <[email protected]>
theStack
force-pushed
the
remove_deprecated_privkey_aliases
branch
from
5ce9b57 to
37d2c60
Compare
|
Rebased on master and simplified the changelog as suggested in #1593 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These function aliases have been described as DEPRECATED in the public API docs already many years ago (see #701, commit 41fc785), and in addition explicit deprecation warnings are shown by the compiler at least since the first official release 0.2.0 (see PR #1089, commit fc94a2d), so it should be fine to just remove them by now without causing bad surprises to any users.
Note that this PR intentionally doesn't include other deprecated flags/types/aliases by now, as they all have been introduced or marked as deprecated later (though the compiler deprecation warnings have been introduced at the same time). There are no deprecation rules yet and seemingly no removal of deprecated types/functions has ever happened so far, so it might make sense to discuss how to handle deprecation in general and introduce guidelines in the future.