Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secp256k1_fe_const_b #1282

Closed
wants to merge 1 commit into from
Closed

Remove secp256k1_fe_const_b #1282

wants to merge 1 commit into from

Conversation

roconnor-blockstream
Copy link
Contributor

It's last use was eliminated in #1217.

@roconnor-blockstream
Remove secp256k1_fe_const_b
d6be470 
It's last use was eliminated in bitcoin-core#1217.
real-or-random
real-or-random approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d6be470

@sipa
Copy link
Contributor

sipa commented Apr 20, 2023 

src/tests.c: In function 'ecmult_const_mult_xonly':
src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'?
 4501 |             secp256k1_fe_add(&c, &secp256k1_fe_const_b);
      |                                   ^~~~~~~~~~~~~~~~~~~~
      |                                   secp256k1_ge_const_g

It would appear that #1118 added another use back (which can easily be converted to secp256k1_fe_add_int() instead).

@real-or-random
Copy link
Contributor 

src/tests.c: In function 'ecmult_const_mult_xonly':
src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'?
 4501 |             secp256k1_fe_add(&c, &secp256k1_fe_const_b);
      |                                   ^~~~~~~~~~~~~~~~~~~~
      |                                   secp256k1_ge_const_g

It would appear that #1118 added another use back (which can easily be converted to secp256k1_fe_add_int() instead.)

By the way, this shows that it's a good idea to remove secp256k1_fe_const_b to make sure that noone will use it in the future.

@sipa
Copy link
Contributor

sipa commented Apr 20, 2023

See #1283 for a fix.

@sipa sipa mentioned this pull request Apr 20, 2023
Merged
real-or-random added a commit that referenced this pull request Apr 21, 2023
@real-or-random
Merge #1283: Get rid of secp256k1_fe_const_b
f6bef03 
69e1ec0 Get rid of secp256k1_fe_const_b (Pieter Wuille)

Pull request description:

  Replaces #1282.

  Its only remaining use is in a test introduced in #1118, and it is easily replaced by the new `secp256k1_fe_add_int` from #1217.

ACKs for top commit:
  real-or-random:
    utACK 69e1ec0

Tree-SHA512: 6ada192e0643fc5326198b60f019a5081444f9ba0a5b8ba6236f2a526829d8e5e479556600a604d9bc96c7ba86e3aab813f93c66679287d2135e95a2b75f5d3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roconnor-blockstream @sipa @real-or-random