Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: customizable AR and RANLIB #1086

Closed
wants to merge 1 commit into from
Closed

configure: customizable AR and RANLIB #1086

wants to merge 1 commit into from

Conversation

jb55
Copy link

@jb55 jb55 commented Mar 12, 2022 •
edited
Loading

This is needed for emscripten wasm builds

Might be related: rust-bitcoin/rust-secp256k1#283 since I was hitting the same error message that the rust wasm builds were hitting.

Signed-off-by: William Casarin [email protected]

@jb55
configure: customizable AR and RANLIB
7308ed0 
This is needed for emscripten wasm builds

Signed-off-by: William Casarin <[email protected]>
@real-or-random real-or-random mentioned this pull request Mar 13, 2022
Merged
@real-or-random
Copy link
Contributor

real-or-random commented Mar 13, 2022 •
edited
Loading

It's a nice discovery that the wasm failure is related to ar. Can you test #1088 instead? I think that's the modern and recommended to solve the problem.

edit: After thinking more about this, I actually don't know why the current code fails. But I still think #1088 is the way to go, if it works.

@jb55
Copy link
Author

jb55 commented Mar 14, 2022

Closing in favor of #1088

@jb55 jb55 closed this Mar 14, 2022
@jb55 jb55 deleted the wasm-emscripten-applem1 branch March 14, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jb55 @real-or-random