Clean up compiler warnings and enable them #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning in the tests.
Wno-unused-function is used for the moment because of the checking functions which are currently only used by VERIFY but are not (yet?) ifdefed out in normal builds.
|
utACK |
sipa
added a commit
that referenced
this pull request
Nov 13, 2014
a099073 Enable warnings. (Gregory Maxwell) 861f9a5 field_gmp's negate doesn't need to use the magnitude argument. (Gregory Maxwell) f0709ac Avoid forward static decl of undefined functions, also fix a paren warning in the tests. (Gregory Maxwell) 3276e7d Signed/unsigned comparisons in tests. (Gregory Maxwell) 850562e Avoid unsigned comparison in scalar arith. (Gregory Maxwell) 65a14ab Fix varrious signed/unsigned comparisons. (Gregory Maxwell) e9e0e21 Avoid a shadowed variable. (Gregory Maxwell) e28a8b8 Remove a VERIFY_CHECK for >=0ness on an unsigned type. (Gregory Maxwell) 2cad067 Correct function prototypes and avoid unused parameter warnings. (Gregory Maxwell) a4a43d7 Reorder static to comply with C99 and switch to the inline macro. (Gregory Maxwell)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't quite go all the way, in that leaves unused function warnings disabled for the moment.