Don't rely on memset to set signed integers to 0

bitcoin-core · Apr 27, 2020 · 6dc08e7 · 6dc08e7
1 parent b8b9462
commit 6dc08e7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/ecmult_impl.h b/src/ecmult_impl.h
@@ -406,14 +406,17 @@ static int secp256k1_ecmult_wnaf(int *wnaf, int len, const secp256k1_scalar *a,
     VERIFY_CHECK(a != NULL);
     VERIFY_CHECK(2 <= w && w <= 31);
 
-    memset(wnaf, 0, len * sizeof(wnaf[0]));
+    for (bit = 0; bit < len; bit++) {
+        wnaf[bit] = 0;
+    }
 
     s = *a;
     if (secp256k1_scalar_get_bits(&s, 255, 1)) {
         secp256k1_scalar_negate(&s, &s);
         sign = -1;
     }
 
+    bit = 0;
     while (bit < len) {
         int now;
         int word;