-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translator comment for Restore Wallet QInputDialog
#629
Conversation
QInputDialog
QInputDialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d7207df, verified using make -C src translate
.
#629 (comment) and #629 (review) were addressed in 643e27e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translator comments look good enough to me, maybe could do the following if you believe it's an improvement?
--- a/src/qt/bitcoingui.cpp
+++ b/src/qt/bitcoingui.cpp
@@ -430,9 +430,10 @@ void BitcoinGUI::createActions()
if (backup_file.isEmpty()) return;
bool wallet_name_ok;
- //: Title of the Restore Wallet input dialog (where the wallet name is entered).
+ /*: Title of pop-up window shown when the user is attempting to
+ restore a wallet. */
QString title = tr("Restore Wallet");
- //: Label of the Restore Wallet input dialog (where the wallet name is entered).
+ //: Label of the input field where the name of the wallet is entered.
QString label = tr("Wallet Name");
QString wallet_name = QInputDialog::getText(this, title, label, QLineEdit::Normal, "", &wallet_name_ok);
if (!wallet_name_ok || wallet_name.isEmpty()) return;
This also changes the window title name from `Restore Name` to `Restore Wallet`.
#629 (review) addressed in 9d9a098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reACK 9d9a098
Changes since my last review:
- The translator's comments have been updated.
I feel the updated translator comments are an improvement and better clarify the purpose of the title and label Qstrings.
… `QInputDialog` 9d9a098 gui: Fix translator comment for Restore Wallet QInputDialog (w0xlt) Pull request description: Fix translator comment for Restore Wallet `QInputDialog`, as suggested in bitcoin-core/gui#471 (comment). This also changes the window title name from `Restore Name` to `Restore Wallet` as it seems clearer. ACKs for top commit: shaavan: reACK 9d9a098 Tree-SHA512: 02aec661839215ab1183e4e92fa131671daa986339373a87c0a0e2c5e79a46f362a8846f4a5f6d630a99884a7949031982d13352336bd3f0573625826406dde8
5f28fc8 qt: Cleanup translation comment (Hennadii Stepanov) Pull request description: An unneeded character slipped in #629. ACKs for top commit: jarolrod: ACK 5f28fc8 jonatack: utACK 5f28fc8 Tree-SHA512: 210fb626e8035786cf6859160c60b2815c813e02908c75efc71a2c64d511edd6f81b2f67f1c98b29122b990260ebf663da445ea2d01b6268e3e046ada1ca5b6e
5f28fc8 qt: Cleanup translation comment (Hennadii Stepanov) Pull request description: An unneeded character slipped in bitcoin-core/gui#629. ACKs for top commit: jarolrod: ACK 5f28fc8 jonatack: utACK 5f28fc8 Tree-SHA512: 210fb626e8035786cf6859160c60b2815c813e02908c75efc71a2c64d511edd6f81b2f67f1c98b29122b990260ebf663da445ea2d01b6268e3e046ada1ca5b6e
Fix translator comment for Restore Wallet
QInputDialog
, as suggested in #471 (comment).This also changes the window title name from
Restore Name
toRestore Wallet
as it seems clearer.