Make error message layout consistent

[w0xlt]

Currently, the error message for invalid change address is displayed on the right while in the "Pay to" and "Address" fields do not show the error message, as commented in #553 (comment).

This PR makes the address error feedback consistent across all fields.

Supersede #534

master

PR

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	Rspigler
Concept ACK	RandyMcMillan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #612 (refactor: Drop unused QFrames in SendCoinsEntry by hebasto)
• #534 (Add translatable address error message by w0xlt)
• #533 (Add more detailed address error message by w0xlt)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[katesalazar]

I assume in this figure there is a static placeholder for the red label (normally empty):

I assume that's regular P2WPKH invoice address you are showing.

Would mean the destination address box be shorter. So what happens if destination address is a longer P2WSH address? Would it then clip while with the current code it would not?

[RandyMcMillan]

Concept ACK

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[Rspigler]

tACK commit 9d75184

Tested all address types in the 'Pay To', 'Custom Change Address', and 'New Send Address' fields.

Just noting that it says "Warning: Invalid Bitcoin address" immediately, but only highlights red when you click out of the text box. I don't know if I have a preference there. But I like the change.

I get this message when opening:

QVariant::load: unknown user type with name BitcoinUnits::Unit.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[hebasto]

Closing this due to lack of activity. Feel free to reopen.