Network Watch tool #444
Network Watch tool #444
Conversation
|
Concept ACK In general, I'm in favor of not having tons of pop-out windows. May be worth exploring this as a new tab. If possible, can you include screenshots of this in action in the OP? |
|
Not sure how to add inline images on GitHub, but there's a sceenshot on the wiki: https://en.bitcoin.it/wiki/File:Bitcoinknots-netwatch.png |
|
As for "pop out windows", I think that's the correct UX for features like this. Having a tab in the main window just doesn't seem to fit well. Maybe a new debug-window-alike for statistics? |
There was a problem hiding this comment.
Have not yet reviewed the code, but:
Commit 47711fd must be broken off and opened in the core repo if it is needed. Then this can be based on the PR that would be open. The change to to validationinterface cannot be done in this repo.
Additionally, the commit history is not clean. The last 4 commits could be squashed onto ae6804e
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…eing unregistered
Simple realtime log of p2p network activity (blocks and transactions only) - Doesn't begin logging until opened; limited to 0x400 entries (outputs) - Automatically scrolls if left at the bottom of the log; maintains position if left elsewhere - Memory-efficient circular buffer; CTransaction references become weak after they're 0x200 entries back in the log - Search function that selects all matching log entries, including ongoing
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
concept NACK - at least, so far, I'm struggling to understand the use case for this. I'd have thought something more command line would make sense, as surely there'd be so much data that it would scroll by too quickly to be useful. |
|
Concept ACK if I'm understanding from the earlier PR. Suggest describing what it does and the use case (what and why) in the pull description. |
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
2 similar comments
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
Closing this due to lack of activity. Feel free to reopen. |
Now that the crash bug (bitcoinknots/bitcoin#4) has been tracked down, this seems ready for re-opening for Core.
(Originally bitcoin/bitcoin#9849)