-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make row color alternating in the Peers tab optional #307
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,30 +44,31 @@ class OptionsModel : public QAbstractListModel | |
explicit OptionsModel(QObject *parent = nullptr, bool resetSettings = false); | ||
|
||
enum OptionID { | ||
StartAtStartup, // bool | ||
ShowTrayIcon, // bool | ||
MinimizeToTray, // bool | ||
MapPortUPnP, // bool | ||
MapPortNatpmp, // bool | ||
MinimizeOnClose, // bool | ||
ProxyUse, // bool | ||
ProxyIP, // QString | ||
ProxyPort, // int | ||
ProxyUseTor, // bool | ||
ProxyIPTor, // QString | ||
ProxyPortTor, // int | ||
DisplayUnit, // BitcoinUnits::Unit | ||
ThirdPartyTxUrls, // QString | ||
Language, // QString | ||
UseEmbeddedMonospacedFont, // bool | ||
CoinControlFeatures, // bool | ||
ThreadsScriptVerif, // int | ||
Prune, // bool | ||
PruneSize, // int | ||
DatabaseCache, // int | ||
ExternalSignerPath, // QString | ||
SpendZeroConfChange, // bool | ||
Listen, // bool | ||
StartAtStartup, // bool | ||
ShowTrayIcon, // bool | ||
MinimizeToTray, // bool | ||
MapPortUPnP, // bool | ||
MapPortNatpmp, // bool | ||
MinimizeOnClose, // bool | ||
ProxyUse, // bool | ||
ProxyIP, // QString | ||
ProxyPort, // int | ||
ProxyUseTor, // bool | ||
ProxyIPTor, // QString | ||
ProxyPortTor, // int | ||
DisplayUnit, // BitcoinUnits::Unit | ||
ThirdPartyTxUrls, // QString | ||
Language, // QString | ||
UseEmbeddedMonospacedFont, // bool | ||
PeersTabAlternatingRowColors, // bool | ||
CoinControlFeatures, // bool | ||
ThreadsScriptVerif, // int | ||
Prune, // bool | ||
PruneSize, // int | ||
DatabaseCache, // int | ||
ExternalSignerPath, // QString | ||
SpendZeroConfChange, // bool | ||
Listen, // bool | ||
OptionIDRowCount, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit in 217d42b While here, you could document the type here is Additionally, if you have to retouch, you could rename the commit from: to:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I don't think it is required to document the type of a counter, as it is not an option id. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Done in the recent push. |
||
}; | ||
|
||
|
@@ -87,6 +88,7 @@ class OptionsModel : public QAbstractListModel | |
int getDisplayUnit() const { return nDisplayUnit; } | ||
QString getThirdPartyTxUrls() const { return strThirdPartyTxUrls; } | ||
bool getUseEmbeddedMonospacedFont() const { return m_use_embedded_monospaced_font; } | ||
bool getPeersTabAlternatingRowColors() const { return m_peers_tab_alternating_row_colors; } | ||
bool getCoinControlFeatures() const { return fCoinControlFeatures; } | ||
const QString& getOverriddenByCommandLine() { return strOverriddenByCommandLine; } | ||
|
||
|
@@ -111,6 +113,7 @@ class OptionsModel : public QAbstractListModel | |
int nDisplayUnit; | ||
QString strThirdPartyTxUrls; | ||
bool m_use_embedded_monospaced_font; | ||
bool m_peers_tab_alternating_row_colors; | ||
bool fCoinControlFeatures; | ||
/* settings that were overridden by command-line */ | ||
QString strOverriddenByCommandLine; | ||
|
@@ -125,6 +128,7 @@ class OptionsModel : public QAbstractListModel | |
void coinControlFeaturesChanged(bool); | ||
void showTrayIconChanged(bool); | ||
void useEmbeddedMonospacedFontChanged(bool); | ||
void peersTabAlternatingRowColorsChanged(bool); | ||
}; | ||
|
||
#endif // BITCOIN_QT_OPTIONSMODEL_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
there's not really a reason to change the size here. I guess this is a good place to answer a question:
"When adding new settings, should we maintain a certain level of padding between the last setting option and its enclosing box?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that successive openings and closings of the
optionsdialog.ui
in Qt Designer won't suggest size changes.