Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Activity feature #57

Open
fanquake opened this issue Aug 14, 2020 · 2 comments
Open

RFC: Activity feature #57

fanquake opened this issue Aug 14, 2020 · 2 comments

Comments

@fanquake
Copy link
Member

Moved from bitcoin/bitcoin#11826.

This is a RFC regarding adding a new Activity window in the UI, which allows to:

  • have activity history (truncated, etc);
  • pause or cancel tasks if supported individually;
  • have multiple progresses concurrently.

In terms of patch, ShowProgress() signal is removed everywhere and a RAII class is added along with some UI classes:

class Activity
{
    std::shared_ptr<ActivityData> const d;
public:
    Activity(const std::string& title);
    ~Activity();

    void SetTitle(const std::string& title);
    void SetProgress(int progress);
};

Consider this the minimal interface for an activity. Some other ideas:

  • custom progress range (so the caller doesn't have to calculate percentage)
  • add something like SetPause(bool), IsPaused();
  • also Cancel() and IsCancelled();
  • add something like SetSource(string) (for instance SetSource("wallet1")).

The current implementation is thread safe. For now, I've also added a new menu item Window where I think we could add Console too (another discussion thou).

Please see the capture below.

dec-05-2017 02-01-28

@Sjors
Copy link
Member

Sjors commented Aug 28, 2020

I would prefer to add this as a tab in the Debug Window. Alternatively it could be inside the console tab.

@jonasschnelli
Copy link
Contributor

Nice. Concept ACK.
I think an independent window makes most sense (its also how other app handle "activities"). Clutching everything into the debug window is one possibility, though I prefer the flexible multi-window approach.

fanquake added a commit that referenced this issue Oct 20, 2021
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues
135254331e Import fixes for sanitizer reported issues
d5fb86940e refactor: use c++11 range based for loop in checkObject
ff9c379304 refactor: Use nullptr (c++11) instead of NULL
08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support
66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus
808d487292 ci: travis -> cirrus
c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration
4a5b0a1c65 build: Move source entries out to sources.mk
6c7d94b33c build: cleanup wonky gen usage
a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23
f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD
1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix
92bdd11f0b univalue_write: remove unneeded sstream.h include
ffb621c130 Merge pull request #56 from drodil/remove_sstream_header
f33acf9fe8 Merge commit '7890db9~' into HEAD
66e0adec4d Remove unnecessary sstream header from univalue.h
88967f6586 Version 1.0.4
1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool
72392fb227 [tests] test pushKV for boolean values
c23132bcf4 Pushing boolean value to univalue correctly
81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS
b17634ef24 Update URLs to MIT license.
88ab64f6b5 Merge pull request #46 from jasonbcox/master
35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit
420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test

git-subtree-dir: src/univalue
git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants