Selected peer in the "Peers" tab gets unselected if any previous peer disconnects

[hebasto]

On master(209974d) the selected peer in the "Peers" tab gets unselected if any previous peer (in the upper rows) disconnects.

Step 1 -- connected three peers, and "peerC" has been selected:

Step 2 -- new connected peers ("peerD") do not hurt:

Step 3 -- but disconnection of any peer from upper rows (e.g., "peerB") causes the loss of peer selection:

[jarolrod]

This bug no longer operates in the way described. I have not investigated fully, but I believe that #18 fixed this bug as it is currently described. There is still a bug related to peer selection that exists and it is fixed by #164.

New Bug:
on master, if you select a peer, and a peer above it disconnects or is disconnected, the selection will slip to the next available peer.

Select Peer 6	Disconnect Peer 0, Peer 7 is now selected

As shown in the screenshots above, we start by selecting Peer 6: 149.248.3.82:38333. Peer 0 is then disconnected, our selection then slips to Peer 7: 88.99.101.67:38333.

#164 Fixes New Bug:
So while the bug has changed, I can confirm that #164 fixes this.

Select Peer 9	Disconnect Peer 1, Peer 6 remains Selected

The screenshots above were taken on Linux on branch #164. We can see that we start with Peer 9: 149.248.3.82:38333, then we disconnect Peer 1. Our selection remains with Peer 9 and does not slip.