Skip to content

Commit

Permalink
Merge bitcoin/bitcoin#23314: build: explicitly disable libsecp256k1 o…
Browse files Browse the repository at this point in the history
…penssl based tests

d752454 build: explicitly disable libsecp256k1 openssl based tests (fanquake)

Pull request description:

  These tests are failing when run against OpenSSL 3, and have been
  removed upstream, bitcoin-core/secp256k1#983, so
  disabled them for now to avoid `make check` failures.

  Note that this will also remove warning output from our build, due to
  the use of deprecated OpenSSL API functions. See bitcoin#23048.

ACKs for top commit:
  MarcoFalke:
    cr ACK d752454
  elichai:
    Code review ACK d752454

Tree-SHA512: a3805b4123ec49aaf21378066d86be382d11a022a7530682c2d8c0e756e785f32f18bea6fe73b1eca73f70bc3aee9166c391a9bf6adc0e450ebb0ce0bcf5a45e
  • Loading branch information
laanwj committed Oct 20, 2021
2 parents c8e68b4 + d752454 commit d807ace
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1878,7 +1878,7 @@ PKGCONFIG_LIBDIR_TEMP="$PKG_CONFIG_LIBDIR"
unset PKG_CONFIG_LIBDIR
PKG_CONFIG_LIBDIR="$PKGCONFIG_LIBDIR_TEMP"

ac_configure_args="${ac_configure_args} --disable-shared --with-pic --enable-benchmark=no --enable-module-recovery --enable-module-schnorrsig --enable-experimental"
ac_configure_args="${ac_configure_args} --disable-shared --with-pic --enable-benchmark=no --enable-module-recovery --enable-module-schnorrsig --enable-experimental --disable-openssl-tests"
AC_CONFIG_SUBDIRS([src/secp256k1])

AC_OUTPUT
Expand Down

0 comments on commit d807ace

Please sign in to comment.