Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4.2 Debugger Visuals #345

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

Snaiel
Copy link
Contributor

@Snaiel Snaiel commented Jun 26, 2024

Addressed issues

Description

Fixes the debugger visuals for 4.2.

I renamed

  • frames.gd
  • graph_edit.gd
  • graph_node.gd

to

  • old_frames.gd
  • old_graph_edit.gd
  • old_graph_node.gd

respectively. Then created

  • new_frames.gd
  • new_graph_edit.gd
  • new_graph_node.gd

for the 4.2+ version

This was done because the changes are big and there's a good possibility that there will be more changes to GraphNode and GraphEdit in the future that doing checks in the same file to support both versions seems like it'd be too messy. Now, the old files just have to worry about versions before 4.2 and the new files can deal with 4.2 and up.

The engine version is checked in the debugger tab to load the correct graph edit file and same in the plugin file to load the correct frames file. The graph edit files load their corresponding graph node files.

You can better see the changes made to get the visuals to work here:

Snaiel/Godot4ThirdPersonCombatPrototype@4d340b6...0f44daa

I also removed the checks for the engine version (checking if a method exists) in the old and new files since they're now only used in one version.

2024-06-27.00-43-07.mp4

@Snaiel Snaiel marked this pull request as ready for review June 26, 2024 16:56
@Snaiel
Copy link
Contributor Author

Snaiel commented Jun 26, 2024

This makes debugger_test.gd fail. Looking into

line 71: Godot Runtime Error !
	'at: _ready (res://addons/beehave/debug/new_graph_node.gd:71)'
Error: 'Trying to assign value of type 'FontFile' to a variable of type 'FontVariation'.'

@Snaiel
Copy link
Contributor Author

Snaiel commented Jun 26, 2024

Also orphans found in debugger_test.gd

@bitbrain
Copy link
Owner

This bothered me for so long but never had the time to look into it properly. Thank you so much!

@bitbrain bitbrain merged commit 42984eb into bitbrain:godot-4.x Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger visuals broken in 4.2
2 participants