Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound is not playing on Safari (solution) #2

Open
markuso opened this issue Jun 16, 2015 · 1 comment
Open

Sound is not playing on Safari (solution) #2

markuso opened this issue Jun 16, 2015 · 1 comment

Comments

@markuso
Copy link

markuso commented Jun 16, 2015

On desktop and mobile Safari (Mac OSX and iOS), the sounds never play and after debugging it was complaining about line 22 and 34 not having the correct parameter passed to them.

I was able to solve it by changing osc.start() and osc.stop() to their proper form osc.start(0) and osc.stop(0) – it looks like on Chrome they automatically assume 0 value, but not on Safari.
@nickells
Copy link

Hey, I came here to say the same thing. Had the same solution too. Nice job!

nickells added a commit to nickells/tones that referenced this issue Aug 12, 2015
@nickells
Fixes Safari playback as per issue bit101#2
18ff3b8 
added zeroes to function invocations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markuso @nickells