Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localhost for notification server #6

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Use localhost for notification server #6

merged 1 commit into from
Sep 1, 2019

Conversation

chimp1984
Copy link

Fixes #5

@mrosseel
Copy link

mrosseel commented Sep 1, 2019

Is this configurable? #5 discusses this. If you run in docker containers btcd and seednode run on different hosts. Please give some more context on how you interpret #5 and how this PR would work with docker ok installations

@sqrrm
Copy link
Member

sqrrm commented Sep 1, 2019

Is this configurable? #5 discusses this. If you run in docker containers btcd and seednode run on different hosts. Please give some more context on how you interpret #5 and how this PR would work with docker ok installations

Doesn't look easy to make configurable, best would be if you could forward the port to the docker container I think.

@chimp1984
Copy link
Author

@mrosseel Feel free to provide a PR for supporting an option for the host.

sqrrm
sqrrm approved these changes Sep 1, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit b8be37b into bisq-network:master Sep 1, 2019
@chimp1984 chimp1984 deleted the listen-localhost-only branch September 1, 2019 21:30
@chimp1984 chimp1984 mentioned this pull request Sep 1, 2019
Closed
@sqrrm sqrrm mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use only localhost for block notify port
3 participants
@chimp1984 @mrosseel @sqrrm