Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact: m/account: Nullable -> Optional #1631 #2947

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Refact: m/account: Nullable -> Optional #1631 #2947

merged 1 commit into from
Oct 23, 2024

Conversation

bsc7
Copy link
Contributor

@bsc7 bsc7 commented Oct 22, 2024

see also #1106

HenrikJannsen
HenrikJannsen approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 7e782fe into bisq-network:main Oct 23, 2024
8 checks passed
@HenrikJannsen
Copy link
Contributor

Thanks for your first PR!!!

@bsc7 bsc7 mentioned this pull request Oct 23, 2024
Open
@bsc7 bsc7 deleted the feature/1631/replace-nullable-with-optional branch October 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsc7 @HenrikJannsen